[Bugfix] Sync MRotaryEmbedding interface change to recover CI #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 27.39% 27.21% -0.19%
==========================================
Files 56 56
Lines 6191 6214 +23
==========================================
- Hits 1696 1691 -5
- Misses 4495 4523 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
please make 0.9.1 works as well |
Collaborator
Author
ok |
wangxiyuan
approved these changes
Jun 24, 2025
Yikun
changed the title
Collaborator
|
Merge to main to recover CI |
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jun 30, 2025
…roject#1399) ### What this PR does / why we need it? Sync MRotaryEmbedding interface change to recover main CI (vllm-project/vllm#19939) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed --------- Signed-off-by: wangli <wangli858794774@gmail.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
…roject#1399) ### What this PR does / why we need it? Sync MRotaryEmbedding interface change to recover main CI (vllm-project/vllm#19939) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed --------- Signed-off-by: wangli <wangli858794774@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
…roject#1399) ### What this PR does / why we need it? Sync MRotaryEmbedding interface change to recover main CI (vllm-project/vllm#19939) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed --------- Signed-off-by: wangli <wangli858794774@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Sync MRotaryEmbedding interface change to recover main CI (vllm-project/vllm#19939)
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed