[Perf][MoE] Improve shared experts multi-stream for w8a8 dynamic. #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: whx-sjtu <2952154980@qq.com>
ganyi1996ppo
approved these changes
Jul 3, 2025
ganyi1996ppo
approved these changes
Jul 3, 2025
| layer.w2_weight.data, ACL_FORMAT_FRACTAL_NZ) | ||
| layer.w13_weight_scale.data = layer.w13_weight_scale.data.view( | ||
| layer.w13_weight_scale.data.shape[0], -1) | ||
| layer.w13_weight_scale_fp32 = layer.w13_weight_scale.data.to( |
There was a problem hiding this comment.
Why does w13_weight_scale need to be converted to fp32?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR designs the shared expert multi-stream parallelism of w8a8-dynamic-quantized MoE stage in more detail to achieve better performance.
Current multi-stream parallel for shared experts are shown in following pic:
Performance change：
Before：
After：