[BUGFIX] qwen2.5-vl failed after PR24444, provide a temp solution #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
xuechendi
requested review from
adobrzyn,
kzawora-intel and
mswiniarsk
as code owners
kzawora-intel
approved these changes
Sep 12, 2025
Collaborator
|
/run-gaudi-tests |
Merged
xuechendi
added a commit
that referenced
this pull request
Sep 16, 2025
- HPU Mrope implementation had a bug which was exposed by vllm-project/vllm#24444 - Initial workaround was to use the default implementation: #162 - This PR fixes the bug in the HPU mrope --------- Signed-off-by: attafosu <thomas.atta-fosu@intel.com> Co-authored-by: Chendi.Xue <chendi.xue@intel.com>
slokesha
pushed a commit
to slokesha/vllm-gaudi
that referenced
this pull request
Sep 24, 2025
- HPU Mrope implementation had a bug which was exposed by vllm-project/vllm#24444 - Initial workaround was to use the default implementation: vllm-project#162 - This PR fixes the bug in the HPU mrope --------- Signed-off-by: attafosu <thomas.atta-fosu@intel.com> Co-authored-by: Chendi.Xue <chendi.xue@intel.com> Signed-off-by: slokesha <slokeshappa@habana.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason qwen2.5-vl failed after PR24444 is because that HPU is kept using forward_native for MRotaryEmbedding
After PR24444 merged, it firstly time will go forward_oot instead of forward_native, while forward_oot is not implemented correctly.
Temporary switch to use forward_native in this PR