address comments

Signed-off-by: Chenheli Hua <huachenheli@outlook.com>

Author: huachenheli

vllm/multimodal/registry.py

@@ -2,7 +2,7 @@
 # SPDX-FileCopyrightText: Copyright contributors to the vLLM project
 from collections.abc import Mapping
 from dataclasses import dataclass
-from typing import TYPE_CHECKING, Any, Generic, Protocol, TypeVar
+from typing import TYPE_CHECKING, Generic, Protocol, TypeVar
 
 import torch.nn as nn
 
@@ -358,20 +358,3 @@ def get_encdec_max_encoder_len(self, model_config: "ModelConfig") -> int:
 
         first_modality = next(iter(max_tokens))
         return max_tokens[first_modality]
-
-
-class ExtensionManager:
-    def __init__(self) -> None:
-        self.name2class: dict[str, type] = {}
-
-    def register(self, name: str):
-        def wrap(cls_to_register):
-            self.name2class[name] = cls_to_register
-            return cls_to_register
-
-        return wrap
-
-    def load(self, cls_name: str, *args, **kwargs) -> Any:
-        cls = self.name2class.get(cls_name)
-        assert cls is not None, f"Extension class {cls_name} not found"
-        return cls(*args, **kwargs)

vllm/multimodal/utils.py

@@ -19,8 +19,8 @@
 import vllm.envs as envs
 from vllm.connections import HTTPConnection, global_http_connection
 from vllm.logger import init_logger
-from vllm.multimodal.registry import ExtensionManager
 from vllm.utils.jsontree import json_map_leaves
+from vllm.utils.registry import ExtensionManager
 
 from .audio import AudioMediaIO
 from .base import MediaIO

vllm/multimodal/video.py

@@ -14,7 +14,7 @@
 
 from vllm import envs
 from vllm.logger import init_logger
-from vllm.multimodal.registry import ExtensionManager
+from vllm.utils.registry import ExtensionManager
 
 from .base import MediaIO
 from .image import ImageMediaIO

vllm/utils/registry.py

@@ -0,0 +1,20 @@
+# SPDX-License-Identifier: Apache-2.0
+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
+from typing import Any
+
+
+class ExtensionManager:
+    def __init__(self) -> None:
+        self.name2class: dict[str, type] = {}
+
+    def register(self, name: str):
+        def wrap(cls_to_register):
+            self.name2class[name] = cls_to_register
+            return cls_to_register
+
+        return wrap
+
+    def load(self, cls_name: str, *args, **kwargs) -> Any:
+        cls = self.name2class.get(cls_name)
+        assert cls is not None, f"Extension class {cls_name} not found"
+        return cls(*args, **kwargs)