Skip to content

fix typo of grafana dashboard, with correct datasource #13668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix typo of grafana dashboard, with correct datasource #13668

merged 1 commit into from
Feb 21, 2025

Conversation

@johnzheng1975
Copy link
Contributor

@johnzheng1975 johnzheng1975 commented Feb 21, 2025 •
edited by github-actions bot
Loading

No description provided.

@johnzheng1975
fix typo of grafana dashboard, with correct datasource
81cec39 
Signed-off-by: John Zheng <john.zheng@hp.com>
@github-actions
Copy link

github-actions bot commented Feb 21, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@johnzheng1975
Copy link
Contributor Author

johnzheng1975 commented Feb 21, 2025

This dashboard has a typo, incorrect datasource.
It cannot work, until fix this typo.

Pls review, thanks.

@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) February 21, 2025 17:26
@robertgshaw2-redhat robertgshaw2-redhat merged commit 900edbf into vllm-project:main Feb 21, 2025
31 of 33 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@johnzheng1975 @Akshat-Tripathi
fix typo of grafana dashboard, with correct datasource (vllm-project#…
feaf88e 
…13668)

Signed-off-by: John Zheng <john.zheng@hp.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@johnzheng1975 @lulmer
fix typo of grafana dashboard, with correct datasource (vllm-project#…
ecb835d 
…13668)

Signed-off-by: John Zheng <john.zheng@hp.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@johnzheng1975 @shreyankg
fix typo of grafana dashboard, with correct datasource (vllm-project#…
85ac9bf 
…13668)

Signed-off-by: John Zheng <john.zheng@hp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnzheng1975 @robertgshaw2-redhat