Skip to content

Conversation

@Chenyaaang
Copy link
Contributor

@Chenyaaang Chenyaaang commented Feb 26, 2025

No description provided.

Signed-off-by: Chenyaaang <llccyy1212@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 26, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It would also be good to know how to install torchvision for TPU, I need this for vision

@mgoin mgoin added tpu Related to Google TPUs ready ONLY add when PR is ready to merge/full CI is needed labels Feb 26, 2025
@WoosukKwon
Copy link
Collaborator

Does it need force-merge?

@hmellor
Copy link
Member

hmellor commented Feb 26, 2025

Please also make the change from https://github.com/vllm-project/vllm/pull/13761/files#diff-1a5f6d7d455c2ef7f4db62c143f71c11e2b3179bc6269b901272e1347d2e473d, one of the files has moved since the TPU tests last ran

@hmellor hmellor mentioned this pull request Feb 26, 2025
@mgoin mgoin changed the title use torch2.6 with whl package [TPU] use torch2.6 with whl package Feb 26, 2025
@mgoin mgoin merged commit b27122a into vllm-project:main Feb 26, 2025
41 checks passed
@NickLucche
Copy link
Collaborator

btw this is still not compatible with uv due to the version metadata not matching the name

uv pip install -r requirements-tpu.txt

warning: Ignoring unsupported option in `requirements-tpu.txt`: `--pre` (hint: pass `--pre` on the command line instead)
Resolved 141 packages in 629ms
Prepared 3 packages in 2.50s
error: Failed to install: torch_xla-2.7.0.dev20250124-cp311-cp311-linux_x86_64.whl (torch-xla==2.7.0.dev20250124 (from https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla-2.7.0.dev20250124-cp311-cp311-linux_x86_64.whl))
  Caused by: Wheel version does not match filename: 2.7.0+git6f367df != 2.7.0.dev20250124

Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
Signed-off-by: Chenyaaang <llccyy1212@gmail.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Chenyaaang <llccyy1212@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: Chenyaaang <llccyy1212@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants