Skip to content

Improve the docs for TransformersModel #14147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Improve the docs for TransformersModel #14147

merged 1 commit into from
Mar 3, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Mar 3, 2025

Improve the docs for TransformersModel to:

  • Improve its visibility
  • More clearly explain what it supports
  • More clearly explain what a remote model writer needs to include

@hmellor
Improve the docs for TransformersFallback
28b0373 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor changed the title Improve the docs for TransformersFallback Improve the docs for TransformersModel Mar 3, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 3, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 3, 2025 16:24
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 3, 2025
@DarkLight1337 DarkLight1337 merged commit 98175b2 into vllm-project:main Mar 3, 2025
22 of 24 checks passed
@hmellor hmellor deleted the improve-transformers-fallback-doc branch March 10, 2025 10:55
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
Improve the docs for TransformersModel (vllm-project#14147)
7aa981f 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @shreyankg
Improve the docs for TransformersModel (vllm-project#14147)
be62e5b 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmellor @DarkLight1337