Skip to content

Conversation

@gshtras
Copy link
Collaborator

@gshtras gshtras commented Mar 12, 2025

Follow up to #14245
These adjustments are meant only for fnuz platforms as well

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ProExpertProg
Copy link
Collaborator

This looks great, did you audit all current_platform.is_rocm() callsites?

@gshtras
Copy link
Collaborator Author

gshtras commented Mar 12, 2025

This looks great, did you audit all current_platform.is_rocm() callsites?

As far as I can tell

@ProExpertProg
Copy link
Collaborator

Could you post in vLLM slack once ready to merge (I assume now)?

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 12, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) March 12, 2025 22:39
@vllm-bot vllm-bot merged commit a94a699 into vllm-project:main Mar 13, 2025
47 of 49 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Richard Liu <ricliu@google.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@gshtras gshtras deleted the fnuz_followup_upstream branch April 7, 2025 14:58
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
)

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants