From 3db38615e676c8c9900a8b615e6bcee29e12d1f1 Mon Sep 17 00:00:00 2001 From: mgoin Date: Fri, 4 Apr 2025 11:41:20 +0000 Subject: [PATCH] Fix default behavior and fallback for pp in v1 Signed-off-by: mgoin --- vllm/engine/arg_utils.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vllm/engine/arg_utils.py b/vllm/engine/arg_utils.py index 88723d9f5b74..89c9b67470e6 100644 --- a/vllm/engine/arg_utils.py +++ b/vllm/engine/arg_utils.py @@ -1521,8 +1521,9 @@ def _is_v1_supported_oracle(self, model_config: ModelConfig) -> bool: # PP is supported on V1 with Ray distributed executor, # but off for MP distributed executor for now. if (self.pipeline_parallel_size > 1 - and self.distributed_executor_backend == "mp" - and _warn_or_fallback("PP (MP distributed executor)")): + and self.distributed_executor_backend != "ray"): + name = "Pipeline Parallelism without Ray distributed executor" + _raise_or_fallback(feature_name=name, recommend_to_remove=False) return False # ngram is supported on V1, but off by default for now.