Skip to content

Raise error for data-parallel with benchmark_throughput #16737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

Raise error for data-parallel with benchmark_throughput #16737

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b50a97e
Raise error for data-parallel with benchmark_throughput
kartikx Apr 16, 2025
62d54fc
Update benchmarks/benchmark_throughput.py
kartikx Apr 18, 2025
694e48a
fix formatting
kartikx Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions benchmarks/benchmark_throughput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,13 @@ def validate_args(args):
raise ValueError(
"Tokenizer must be the same as the model for MII backend.")

# --data-parallel is not supported currently.
# https://github.com/vllm-project/vllm/issues/16222
if args.data_parallel_size > 1:
raise ValueError(
"Data parallel is not supported in offline benchmark, \
please use benchmark serving instead")


if __name__ == "__main__":
parser = FlexibleArgumentParser(description="Benchmark the throughput.")
Expand Down