Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented May 3, 2025

Since the existence of input_embeds triggers a separate graph compilation, this PR disables prompt_embeds inputs (#15428) by default. This should revert the engine startup time to normal for most users.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 3, 2025
@DarkLight1337 DarkLight1337 requested a review from njhill May 3, 2025 05:17
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner May 3, 2025 05:17
@github-actions
Copy link

github-actions bot commented May 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added this to the v0.9.0 milestone May 3, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarkLight1337 DarkLight1337 merged commit 887d7af into vllm-project:main May 3, 2025
53 checks passed
@DarkLight1337 DarkLight1337 deleted the prompts-embeds-flag branch May 3, 2025 16:19
@qthequartermasterman
Copy link
Contributor

Asking for clarification. This only affects the availability of prompt embeds if not in eager mode, correct?

If forcing eager mode, no compilation is needed and the prompt embeds are passed to the python implementation of the model regardless of this flag, right?

@DarkLight1337
Copy link
Member Author

For consistency, this flag is required for both eager and graph mode.

RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants