Skip to content

Conversation

@Abatom
Copy link
Contributor

@Abatom Abatom commented May 15, 2025

In our multimodal scenario, when the input image size does not match the model's requirements, the call_hf_processor function throws a RuntimeError.

In the async_llm_engine.py, the engine_step function only catches ValueError, which leads to that the client hangs and cannot exit. If the call_hf_processor function throws a ValueError instead, the client can exit normally.

In fact, an image size mismatch should be considered a ValueError.

Signed-off-by: Abatom <abzhonghua@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat
Copy link
Collaborator

In our multimodal scenario, when the input image size does not match the model's requirements, the call_hf_processor function throws a RuntimeError.

In the async_llm_engine.py, the engine_step function only catches ValueError, which leads to that the client hangs and cannot exit. If the call_hf_processor function throws a ValueError instead, the client can exit normally.

In fact, an image size mismatch should be considered a ValueError.

Does this get called inside generate() or inside output_handler_loop?

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 15, 2025
@Abatom
Copy link
Contributor Author

Abatom commented May 15, 2025

Does this get called inside generate() or inside output_handler_loop?

It is called inside the run_engine_loop.

@vllm-bot vllm-bot merged commit fadb8d5 into vllm-project:main May 15, 2025
62 of 66 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
…Error to ValueError (vllm-project#18181)

Signed-off-by: Abatom <abzhonghua@gmail.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
@Abatom Abatom deleted the input branch June 25, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants