-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Add clear documentation around the impact of debugging flag #19369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @annapendleton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, gemini-code-assist here to provide a summary of this pull request. This PR focuses on improving the documentation within the vllm project. Specifically, it adds important clarification regarding the VLLM_TRACE_FUNCTION=1 debugging flag. The intent, as stated in the PR description and title, is to make it clear that this flag is intended solely for debugging and should not be used otherwise, as it can cause significant delays during startup. This change directly addresses an issue encountered when starting models like gemma-3-1b with vLLM.
Highlights
- Documentation Update: Added a crucial note to the troubleshooting documentation (
docs/usage/troubleshooting.md) explaining the impact and intended use of theVLLM_TRACE_FUNCTION=1environment variable. - Debugging Flag Clarification: Explicitly warned users that enabling
VLLM_TRACE_FUNCTION=1will cause significant delays in startup time and should only be used when absolutely necessary for debugging.
Changelog
- docs/usage/troubleshooting.md
- Added a warning and usage restriction to the description of the
VLLM_TRACE_FUNCTION=1debugging flag (line 43).
- Added a warning and usage restriction to the description of the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses the need for clearer documentation regarding the VLLM_TRACE_FUNCTION=1 flag. The added warning is concise, well-placed, and clearly communicates the potential performance impact and intended use case of this debugging flag. This will be very helpful for users troubleshooting issues and prevent accidental misuse that could lead to significant startup delays, as referenced in the linked issue. Great job on this targeted and impactful documentation improvement!
Merge Readiness
The documentation change in this pull request is clear, accurate, and directly addresses the stated purpose. From a code review perspective, the changes look good and improve the quality of the troubleshooting guide. While I cannot approve the pull request myself, I believe it is ready for merging after any other required reviews and approvals are completed.
Signed-off-by: Anna Pendleton <pendleton@google.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Purpose
Add clear documentation around the flag that caused issues for starting up gemma-3-1b model with vllm, ref: #17386
(Optional) Documentation Update
Make clear that this flag is not to be used in any other way except for debugging.