Revert "[Build/CI] Add tracing deps to vllm container image (#15224)"

[kouroshHakha]

This reverts commit fee5b8d.

Multiple people have reported that it caused problems.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Hello @kouroshHakha, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. This PR, authored by kouroshHakha, is a revert of a previous commit (fee5b8d37f3b2c6e63ff87e98105e5365ec2eb45) which added tracing dependencies to the vLLM container image and requirements. The description indicates that the original change caused problems for multiple users, necessitating this revert to remove those dependencies and associated build steps.

Highlights

• Revert: This pull request fully reverts a previous commit that introduced OpenTelemetry tracing dependencies.
• Dependency Removal: The OpenTelemetry SDK, API, Exporter, and Semantic Conventions for AI dependencies are removed from the project's requirements.
• CI/Build Changes: The step that explicitly installed the tracing dependencies in the Buildkite test pipeline before running tracing tests has been removed.

Changelog

• .buildkite/test-pipeline.yaml
  • Removed the pip install command that added specific OpenTelemetry tracing dependencies before running tracing tests.
• requirements/common.txt
  • Removed the OpenTelemetry SDK, API, Exporter, and Semantic Conventions for AI dependencies from the common requirements file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a previous commit that added OpenTelemetry tracing dependencies to the common requirements, due to reported issues. The change removes these dependencies from requirements/common.txt and instead installs them specifically for the tracing tests within the CI pipeline (test-pipeline.yaml). This is a sensible approach to address the problems while ensuring tests remain functional.

The updated CI configuration also introduces upper bounds for these test-specific dependencies, which is a good practice for build stability. My main suggestion focuses on further improving the maintainability of how these dependencies are managed in the CI pipeline.

Summary of Findings

• CI Dependency Management: Suggested moving inline pip install commands in .buildkite/test-pipeline.yaml to a dedicated requirements file for improved maintainability and readability (medium severity, commented).
• PR Description Completion: The PR description template is largely unfilled. While this is a revert, completing the 'Purpose' section with a brief explanation of why the revert is necessary (e.g., summarizing the problems caused by the original commit) would be beneficial for future context and record-keeping. (low severity, not commented due to review settings).
• Improved Dependency Pinning in CI: The change to install OpenTelemetry dependencies directly in the CI pipeline for tracing tests also introduced upper bounds for these package versions (e.g., <1.27.0). This is a positive change that enhances the reproducibility and stability of the CI builds for these tests.

Merge Readiness

This PR effectively reverts the problematic commit and ensures tracing tests can still run by installing dependencies in the CI pipeline. The core change is sound.

I have one medium severity suggestion regarding how dependencies are managed in the CI configuration, aimed at improving long-term maintainability. I recommend addressing this suggestion to keep the CI setup clean and easy to manage.

As a reviewer, I am not authorized to approve pull requests. Please ensure further review and approval from authorized maintainers before merging. I recommend addressing the suggested change before merging.

[russellb]

lgtm. assuming CI passes

[kouroshHakha]

Hey @russellb can you take a look at the tests? I think they are unrelated?

[kouroshHakha]

rebasing

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!