Skip to content

Conversation

@Xu-Wenqing
Copy link
Contributor

@Xu-Wenqing Xu-Wenqing commented Jul 25, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Add H20-3e fused MoE kernel tuning configs for Qwen3-Coder-480B-A35B-Instruct

Test Plan

python3.12 -m sglang.bench_serving --tokenizer /Models/qwen/Qwen3-Coder-480B-A35B-Instruct --base-url $ENDPOINT --backend vllm --dataset-name random --random-input 4096 --random-output 1024 --max-concurrency 10 --num-prompt 100

Test Result

Result (without Moe config):

============ Serving Benchmark Result ============
Backend:                                 vllm      
Traffic request rate:                    inf       
Max request concurrency:                 10        
Successful requests:                     100       
Benchmark duration (s):                  167.76    
Total input tokens:                      209281    
Total generated tokens:                  52135     
Total generated tokens (retokenized):    50573     
Request throughput (req/s):              0.60      
Input token throughput (tok/s):          1247.50   
Output token throughput (tok/s):         310.77    
Total token throughput (tok/s):          1558.27   
Concurrency:                             9.63      
----------------End-to-End Latency----------------
Mean E2E Latency (ms):                   16157.84  
Median E2E Latency (ms):                 16501.66  
---------------Time to First Token----------------
Mean TTFT (ms):                          503.36    
Median TTFT (ms):                        390.19    
P99 TTFT (ms):                           2178.79   
---------------Inter-Token Latency----------------
Mean ITL (ms):                           30.29     
Median ITL (ms):                         27.32     
P95 ITL (ms):                            32.46     
P99 ITL (ms):                            163.05    
Max ITL (ms):                            719.39    
==================================================

Result (with Moe config):

============ Serving Benchmark Result ============
Backend:                                 vllm      
Traffic request rate:                    inf       
Max request concurrency:                 10        
Successful requests:                     100       
Benchmark duration (s):                  154.16    
Total input tokens:                      209281    
Total generated tokens:                  52135     
Total generated tokens (retokenized):    50487     
Request throughput (req/s):              0.65      
Input token throughput (tok/s):          1357.52   
Output token throughput (tok/s):         338.18    
Total token throughput (tok/s):          1695.69   
Concurrency:                             9.62      
----------------End-to-End Latency----------------
Mean E2E Latency (ms):                   14834.48  
Median E2E Latency (ms):                 15468.98  
---------------Time to First Token----------------
Mean TTFT (ms):                          551.99    
Median TTFT (ms):                        391.19    
P99 TTFT (ms):                           2423.88   
---------------Inter-Token Latency----------------
Mean ITL (ms):                           27.67     
Median ITL (ms):                         23.42     
P95 ITL (ms):                            96.16     
P99 ITL (ms):                            184.47    
Max ITL (ms):                            913.22    
==================================================

(Optional) Documentation Update

…Instruct

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
…Instruct

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
@mergify mergify bot added the qwen Related to Qwen models label Jul 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new configuration file with tuned parameters for the fused MoE kernel on NVIDIA H20-3e GPUs for the Qwen3-Coder-480B-A35B-Instruct model. The change is straightforward and the provided benchmark results demonstrate a clear performance improvement. The new configuration file is well-structured and follows the existing format. I don't see any issues with this change. Great work!

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@vllm-bot vllm-bot merged commit 8ed01e3 into vllm-project:main Jul 25, 2025
12 of 14 checks passed
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
…Instruct (vllm-project#21598)

Signed-off-by: 许文卿 <xwq391974@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants