-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[CI Perf] Prune tests in tests/kernels/quantization/
#22942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Perf] Prune tests in tests/kernels/quantization/
#22942
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve CI performance by pruning the test suite for quantization kernels. While many of the changes, such as reducing the parameter space for tests and moving to curated test cases, are reasonable optimizations, there is a significant concern. The removal of torch.float16 from the data types being tested in test_fp8_quant.py, test_int8_quant.py, and test_triton_scaled_mm.py could mask potential regressions for this widely used data type. It is recommended to restore testing for torch.float16 to maintain robust test coverage.
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
…22942) Signed-off-by: mgoin <mgoin64@gmail.com>
…22942) Signed-off-by: mgoin <mgoin64@gmail.com>
…22942) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
…22942) Signed-off-by: mgoin <mgoin64@gmail.com>
…22942) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…22942) Signed-off-by: mgoin <mgoin64@gmail.com>
Purpose
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.