-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[UX] Move Dockerfile DeepGEMM install to tools/install_deepgemm.sh #23360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the DeepGEMM installation logic from the Dockerfile into a separate, reusable shell script. This is a good improvement for modularity and reusability. My review focuses on the new script, tools/install_deepgemm.sh, and I've identified a critical issue with argument parsing and a high-severity issue regarding safe directory handling for the build process. Addressing these will make the script more robust and reliable for both Docker builds and local use.
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
Signed-off-by: mgoin <mgoin64@gmail.com>
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
Signed-off-by: mgoin <mgoin64@gmail.com>
…llm-project#23360) Signed-off-by: mgoin <mgoin64@gmail.com>
…llm-project#23360) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…llm-project#23360) Signed-off-by: mgoin <mgoin64@gmail.com>
…llm-project#23360) Signed-off-by: mgoin <mgoin64@gmail.com>
…llm-project#23360) Signed-off-by: mgoin <mgoin64@gmail.com>
…llm-project#23360) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
…llm-project#23360) Signed-off-by: mgoin <mgoin64@gmail.com>
Purpose
Now that we are installing DeepGEMM from source in our Dockerfile, we should pull out the logic into a reusable script for users that are using vllm wheels rather than images.
Test Plan
Tested locally on H100 with my dev vLLM env and installing using
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.