Skip to content

Conversation

@Edwardf0t1
Copy link
Contributor

@Edwardf0t1 Edwardf0t1 commented Sep 8, 2025

Add @Edwardf0t1 as a reviewer for modelopt related files.

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>
@mergify mergify bot added the ci/build label Sep 8, 2025
@Edwardf0t1 Edwardf0t1 force-pushed the zhiyu/update-modelopt-reviewers branch from 91374d4 to 0a1ff87 Compare September 8, 2025 22:35
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Mergify rule to automatically assign a reviewer for changes related to modelopt. The implementation has a critical issue where the conditions are combined with AND instead of the intended OR, which would prevent the rule from triggering correctly. I've provided a suggestion to fix this logic and improve the regular expressions for better accuracy.

Comment on lines 278 to 283
- files~=^vllm/model_executor/layers/quantization/modelopt.py
- files~=^vllm/model_executor/layers/quantization/__init__.py
- files~=^tests/models/quantization/test_modelopt.py
- files~=^tests/quantization/test_modelopt.py
- files~=^tests/models/quantization/test_nvfp4.py
- files~=^docs/features/quantization/modelopt.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The current list of conditions for this rule will be treated as an AND condition by Mergify. This means the rule will only trigger if a pull request modifies all of the listed files simultaneously, which is likely not the intended behavior. To trigger the rule if any of the files are modified, you should use an or block.

Additionally, it's good practice to make the regular expressions more specific by escaping dots (.) and anchoring the match to the end of the string with $.

    - or:
        - files~=^vllm/model_executor/layers/quantization/modelopt\.py$
        - files~=^vllm/model_executor/layers/quantization/__init__\.py$
        - files~=^tests/models/quantization/test_modelopt\.py$
        - files~=^tests/quantization/test_modelopt\.py$
        - files~=^tests/models/quantization/test_nvfp4\.py$
        - files~=^docs/features/quantization/modelopt\.md$

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://docs.mergify.com/configuration/conditions/ I actually don't know if Gemini is hallucinating or not lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated.

Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>
@simon-mo simon-mo enabled auto-merge (squash) September 9, 2025 00:09
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2025
@simon-mo simon-mo merged commit 4f87abd into vllm-project:main Sep 9, 2025
22 checks passed
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants