-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Update reviewers for modelopt related files #24468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reviewers for modelopt related files #24468
Conversation
Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>
91374d4 to
0a1ff87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new Mergify rule to automatically assign a reviewer for changes related to modelopt. The implementation has a critical issue where the conditions are combined with AND instead of the intended OR, which would prevent the rule from triggering correctly. I've provided a suggestion to fix this logic and improve the regular expressions for better accuracy.
.github/mergify.yml
Outdated
| - files~=^vllm/model_executor/layers/quantization/modelopt.py | ||
| - files~=^vllm/model_executor/layers/quantization/__init__.py | ||
| - files~=^tests/models/quantization/test_modelopt.py | ||
| - files~=^tests/quantization/test_modelopt.py | ||
| - files~=^tests/models/quantization/test_nvfp4.py | ||
| - files~=^docs/features/quantization/modelopt.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current list of conditions for this rule will be treated as an AND condition by Mergify. This means the rule will only trigger if a pull request modifies all of the listed files simultaneously, which is likely not the intended behavior. To trigger the rule if any of the files are modified, you should use an or block.
Additionally, it's good practice to make the regular expressions more specific by escaping dots (.) and anchoring the match to the end of the string with $.
- or:
- files~=^vllm/model_executor/layers/quantization/modelopt\.py$
- files~=^vllm/model_executor/layers/quantization/__init__\.py$
- files~=^tests/models/quantization/test_modelopt\.py$
- files~=^tests/quantization/test_modelopt\.py$
- files~=^tests/models/quantization/test_nvfp4\.py$
- files~=^docs/features/quantization/modelopt\.md$There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://docs.mergify.com/configuration/conditions/ I actually don't know if Gemini is hallucinating or not lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Updated.
Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Add @Edwardf0t1 as a reviewer for modelopt related files.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.