test: Remove vestigial skip for prompt embeds tests after landing v1 Prompt Embeds support #25291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-project#24278 Signed-off-by: Andrew Sansom <andrew@protopia.ai>
qthequartermasterman
requested review from
DarkLight1337,
NickLucche,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
5 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a pytest.skip directive from tests/entrypoints/openai/test_completion_with_prompt_embeds.py. The purpose of this change is to re-enable the tests for prompt embeddings, as support for this feature has now been implemented in v1. The change is straightforward, correct, and aligns with the PR's description. I have reviewed the code and found no issues.
DarkLight1337
approved these changes
Sep 20, 2025
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…Prompt Embeds support (vllm-project#25291) Signed-off-by: Andrew Sansom <andrew@protopia.ai>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
…Prompt Embeds support (vllm-project#25291) Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…Prompt Embeds support (#25291) Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…Prompt Embeds support (vllm-project#25291) Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…Prompt Embeds support (vllm-project#25291) Signed-off-by: Andrew Sansom <andrew@protopia.ai>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…Prompt Embeds support (vllm-project#25291) Signed-off-by: Andrew Sansom <andrew@protopia.ai>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…Prompt Embeds support (vllm-project#25291) Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#24278 landed support for v1 Prompt Embeds. #25025 introduced a temporary test skip for prompt embeds support in the API that I had missed when merging in main. This removes that now-unnecessary test skip.
Test Plan
No new tests were needed; just enabling tests that were working two days ago.
Test Result
Tests pass locally. Pending CI.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.