[Bugfix][V0 Deprecation][CI] use async mock and await for async method #25325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKSK-DON
changed the title
KKSK-DON
requested review from
DarkLight1337,
NickLucche,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
5 tasks
ywang96
reviewed
Sep 21, 2025
Member
ywang96
left a comment
ywang96
left a comment
There was a problem hiding this comment.
Seems reasonable for me - I'm curious why our CI didn't catch this?
KKSK-DON
changed the title
DarkLight1337
added
the
ready
Member
|
cc @WoosukKwon |
Contributor
Author
|
I think it is not because we change to AsyncLLM. I check deleted MQLLMEngineClient. The add_lora method is async in there. Looks like the original test method forget to use async mock @DarkLight1337 @ywang96 |
KKSK-DON
force-pushed
the
bugfix/test-lora
branch
2 times, most recently
from
febed9e to
afefccf
Compare
KKSK-DON
force-pushed
the
bugfix/test-lora
branch
from
afefccf to
8e8b7f7
Compare
DarkLight1337
approved these changes
Sep 21, 2025
kingsmad
pushed a commit
to kingsmad/vllm
that referenced
this pull request
Sep 22, 2025
vllm-project#25325) Signed-off-by: Yang <lymailforjob@gmail.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
vllm-project#25325) Signed-off-by: Yang <lymailforjob@gmail.com>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
vllm-project#25325) Signed-off-by: Yang <lymailforjob@gmail.com> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
#25325) Signed-off-by: Yang <lymailforjob@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
vllm-project#25325) Signed-off-by: Yang <lymailforjob@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
vllm-project#25325) Signed-off-by: Yang <lymailforjob@gmail.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
vllm-project#25325) Signed-off-by: Yang <lymailforjob@gmail.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
vllm-project#25325) Signed-off-by: Yang <lymailforjob@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pr is because the AsyncLLM's method is async #25019
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.