[Logging] Remove TORCH_NCCL_AVOID_RECORD_STREAMS to squash a warning #25532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
tlrmchlsmth
requested review from
WoosukKwon,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the setting of the deprecated TORCH_NCCL_AVOID_RECORD_STREAMS environment variable from vllm/v1/worker/gpu_worker.py. As the pull request description correctly points out, this behavior is now default in PyTorch, and setting the variable is obsolete and generates a warning. The change is straightforward and correct, contributing to a cleaner codebase. I have no further comments.
simon-mo
approved these changes
Sep 24, 2025
github-actions
bot
added
the
ready
sergiopaniego
pushed a commit
to sergiopaniego/vllm
that referenced
this pull request
Sep 29, 2025
…llm-project#25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sergiopaniego
pushed a commit
to sergiopaniego/vllm
that referenced
this pull request
Sep 29, 2025
…llm-project#25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: sergiopaniego <sergiopaniegoblanco@gmail.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…llm-project#25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…llm-project#25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…llm-project#25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…llm-project#25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…llm-project#25532) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to set
TORCH_NCCL_AVOID_RECORD_STREAMS, our logs complain: