Skip to content

Conversation

@22quinn
Copy link
Collaborator

@22quinn 22quinn commented Oct 4, 2025

Purpose

for debugging

Test Plan

>>> from vllm.v1.metrics.stats import IterationStats
INFO 10-04 15:05:08 [__init__.py:215] Automatically detected platform cuda.
>>> a = IterationStats()
>>> a
IterationStats(iteration_timestamp=1759615513.896626, num_generation_tokens=0, num_prompt_tokens=0, num_preempted_reqs=0, finished_requests=[], max_num_generation_tokens_iter=[], n_params_iter=[], time_to_first_tokens_iter=[], inter_token_latencies_iter=[], waiting_lora_adapters={}, running_lora_adapters={})
>>> 

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a __repr__ method to the IterationStats class, which is a helpful addition for debugging purposes. The implementation is straightforward and effectively serializes the object's attributes into a string representation. I find no issues with this change.

Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to add some unittest

Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
@22quinn 22quinn enabled auto-merge (squash) October 5, 2025 03:16
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 5, 2025
@22quinn 22quinn merged commit 78c1d5b into vllm-project:main Oct 5, 2025
46 checks passed
tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
karan pushed a commit to karan/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
@22quinn 22quinn deleted the log-IterationStats branch November 16, 2025 22:28
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants