[Frontend][torch.compile] CompilationConfig Overhaul (#20283): name change compilation level to compilation mode, deprecation compilation level #26355

morrison-turnansky · 2025-10-07T14:08:54Z

Purpose

See #20283 (comment)
The purpose of this PR is to perform variable name changes and deprecation warnings for compilation level to compilation mode. Enum values names are also changed. No true changes of behavior nor breaking changes have occurred.

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist

The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
The test plan, such as providing test command.
The test results, such as pasting the results comparison before and after, or e2e results
(Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
(Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

mergify · 2025-10-07T14:09:33Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @morrison-turnansky.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

…ops and utils_/test_utils.py::test_dict_args Signed-off-by: morrison-turnansky <mturnans@redhat.com>

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

zou3519 · 2025-10-15T02:06:34Z

tests/compile/test_basic_correctness.py

+            CompilationMode.STOCK_TORCH_COMPILE,
+            CompilationMode.DYNAMO_TRACE_ONCE,
+            CompilationMode.VLLM_COMPILE,


are all of these 1:1?

If they are... DYNAMO_AS_IS didn't include Inductor previously, but I would expect STOCK_TORCH_COMPILE to include Inductor

zou3519

Mostly LGTM, I am just confused about if Mode.STOCK_TORCH_COMPILE implies torch.compile with inductor. I am hoping it is compositional and that it uses whatever "compilation_config.backend" is. A test would convince me that this is what happens (doesn't need to be in this PR)

ProExpertProg · 2025-10-15T02:42:24Z

Mostly LGTM, I am just confused about if Mode.STOCK_TORCH_COMPILE implies torch.compile with inductor. I am hoping it is compositional and that it uses whatever "compilation_config.backend" is. A test would convince me that this is what happens (doesn't need to be in this PR)

I think we ended up making inductor the default for all modes (except NONE) in the previous PR (#26502). Agreed we should add a test, @morrison-turnansky can you open a follow-up for that when you get a chance? But yeah the goal of the previous PR was to respect CompilationConfig.backend for all levels.

morrison-turnansky · 2025-10-15T12:53:56Z

Issue created: #26911

): name change compilation level to compilation mode, deprecation compilation level (vllm-project#26355) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Signed-off-by: bbartels <benjamin@bartels.dev>

): name change compilation level to compilation mode, deprecation compilation level (vllm-project#26355) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

…m-project#27260) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

…m-project#27260) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>

): name change compilation level to compilation mode, deprecation compilation level (vllm-project#26355) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>

### What this PR does / why we need it? This is the step 1 of refactoring code to adapt with vllm main, and this pr aligned with vllm-project/vllm@17c540a 1. refactor deepseek to the latest code arch as of vllm-project/vllm@17c540a 2. bunches of fixes due to vllm changes - Fix `AscendScheduler` `__post_init__`, caused by vllm-project/vllm#25075 - Fix `AscendScheduler` init got an unexpected arg `block_size`, caused by vllm-project/vllm#26296 - Fix `KVCacheManager` `get_num_common_prefix_blocks` arg, caused by vllm-project/vllm#23485 - Fix `MLAAttention` import,caused by vllm-project/vllm#25103 - Fix `SharedFusedMoE` import, caused by vllm-project/vllm#26145 - Fix `LazyLoader` improt, caused by vllm-project/vllm#27022 - Fix `vllm.utils.swap_dict_values` improt, caused by vllm-project/vllm#26990 - Fix `Backend` enum import, caused by vllm-project/vllm#25893 - Fix `CompilationLevel` renaming to `CompilationMode` issue introduced by vllm-project/vllm#26355 - Fix fused_moe ops, caused by vllm-project/vllm#24097 - Fix bert model because of `inputs_embeds`, caused by vllm-project/vllm#25922 - Fix MRope because of `get_input_positions_tensor` to `get_mrope_input_positions`, caused by vllm-project/vllm#24172 - Fix `splitting_ops` changes introduced by vllm-project/vllm#25845 - Fix multi-modality changes introduced by vllm-project/vllm#16229 - Fix lora bias dropping issue introduced by vllm-project/vllm#25807 - Fix structured ouput break introduced by vllm-project/vllm#26737 ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? CI passed with existing test. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 --------- Signed-off-by: MengqingCao <cmq0113@163.com> Signed-off-by: Icey <1790571317@qq.com> Co-authored-by: Icey <1790571317@qq.com>

): name change compilation level to compilation mode, deprecation compilation level (vllm-project#26355) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>

…m-project#27260) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

): name change compilation level to compilation mode, deprecation compilation level (vllm-project#26355) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>

…m-project#27260) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>

): name change compilation level to compilation mode, deprecation compilation level (vllm-project#26355) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>

…m-project#27260) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>

mergify bot added documentation Improvements or additions to documentation llama Related to Llama models speculative-decoding v1 tpu Related to Google TPUs labels Oct 7, 2025

mergify bot added the needs-rebase label Oct 7, 2025

morrison-turnansky force-pushed the issue-20283-level branch from 4753011 to e347d4d Compare October 7, 2025 14:14

mergify bot removed the needs-rebase label Oct 7, 2025

morrison-turnansky marked this pull request as ready for review October 7, 2025 14:16

morrison-turnansky added 4 commits October 15, 2025 00:23

reviewer comments

6f1385f

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

fixed tests/model_executor/test_enabled_custom_ops.py::test_enabled_…

79708c1

…ops and utils_/test_utils.py::test_dict_args Signed-off-by: morrison-turnansky <mturnans@redhat.com>

reviewer commemnts

e138bdf

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

updated after merge

4a53a64

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

morrison-turnansky force-pushed the issue-20283-level branch from 211fe4a to 4a53a64 Compare October 15, 2025 00:28

ProExpertProg approved these changes Oct 15, 2025

View reviewed changes

zou3519 reviewed Oct 15, 2025

View reviewed changes

ProExpertProg enabled auto-merge (squash) October 15, 2025 02:43

ProExpertProg merged commit 96b9aa5 into vllm-project:main Oct 15, 2025
60 checks passed

ProExpertProg mentioned this pull request Oct 15, 2025

[Feature]: Add test verifying CompilationMode.STOCK_TORCH_COMPILE behavior #26911

Open

1 task

wxsIcey mentioned this pull request Oct 16, 2025

[CI] Upgrade vllm to newest commit vllm-project/vllm-ascend#3423

Closed

hmellor added a commit to hmellor/vllm that referenced this pull request Oct 21, 2025

Remove last level references not removed in vllm-project#26355

85983dd

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

MengqingCao mentioned this pull request Oct 22, 2025

[1/N][Refactor] Refactor code to adapt with vllm main vllm-project/vllm-ascend#3612

Merged

hmellor added a commit that referenced this pull request Oct 22, 2025

Remove last level references not removed in #26355 (#27260)

8f18feb

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

usberkeley pushed a commit to usberkeley/vllm that referenced this pull request Oct 23, 2025

Remove last level references not removed in vllm-project#26355 (vll…

e7ca36b

…m-project#27260) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

kingsmad pushed a commit to kingsmad/vllm that referenced this pull request Oct 25, 2025

Remove last level references not removed in vllm-project#26355 (vll…

105620a

…m-project#27260) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Frontend][torch.compile] CompilationConfig Overhaul (#20283): name change compilation level to compilation mode, deprecation compilation level #26355

[Frontend][torch.compile] CompilationConfig Overhaul (#20283): name change compilation level to compilation mode, deprecation compilation level #26355

Uh oh!

morrison-turnansky commented Oct 7, 2025 •

edited by github-actions bot

Loading

Uh oh!

mergify bot commented Oct 7, 2025

Uh oh!

zou3519 Oct 15, 2025

Uh oh!

zou3519 left a comment •

edited

Loading

Uh oh!

ProExpertProg commented Oct 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

morrison-turnansky commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

[Frontend][torch.compile] CompilationConfig Overhaul (#20283): name change compilation level to compilation mode, deprecation compilation level #26355

[Frontend][torch.compile] CompilationConfig Overhaul (#20283): name change compilation level to compilation mode, deprecation compilation level #26355

Uh oh!

Conversation

morrison-turnansky commented Oct 7, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Test Plan

Test Result

Uh oh!

mergify bot commented Oct 7, 2025

Uh oh!

zou3519 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

zou3519 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ProExpertProg commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

morrison-turnansky commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

morrison-turnansky commented Oct 7, 2025 •

edited by github-actions bot

Loading

zou3519 left a comment •

edited

Loading

ProExpertProg commented Oct 15, 2025 •

edited

Loading