Adjusting AMD test composition 2025-10-14 #26852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
…nto MAIN_20251014
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adjusts the AMD test composition by adding test_aot_compile.py and test_top_k_per_row.py to the test suite. These changes enhance the test coverage for AMD-specific builds. The modifications to the .buildkite/test-amd.yaml file are straightforward and appear correct. I have no specific comments on the changes.
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
khluu
approved these changes
Oct 15, 2025
github-actions
bot
added
the
ready
mandy-li
pushed a commit
to mandy-li/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting AMD test composition 2025-10-14
Signed-off-by: Alexei V. Ivanov alexei.ivanov@amd.com