[V0 Deprecation] Remove V0 executors #27142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

njhill merged 18 commits into vllm-project:main from njhill:rm-v0-executors

Oct 21, 2025

Member

njhill commented Oct 18, 2025

vllm.v1.executors.Executor becomes the base executor class.

njhill requested review from 22quinn, ProExpertProg, WoosukKwon, aarnphm, alexm-redhat, chaunceyjiang, comaniac, hmellor, houseroad, mgoin, robertgshaw2-redhat, simon-mo, tlrmchlsmth, yewentao256, youkaichao and zhuohan123 as code owners

October 18, 2025 05:52

mergify bot added frontend v1 tpu labels

mergify bot assigned sangstar

gemini-code-assist bot reviewed

View reviewed changes

Contributor

gemini-code-assist bot left a comment

Code Review

This pull request is a significant and well-executed refactoring that removes the V0 executors and consolidates the executor logic around the new vllm.v1.executor.Executor base class. The changes are extensive, touching many files to update imports, remove obsolete code and environment variables (VLLM_USE_RAY_SPMD_WORKER, VLLM_USE_RAY_COMPILED_DAG), and align with the new V1 executor API. The new structure is more logical and simplifies the codebase. I have reviewed the changes and found no critical or high-severity issues. The refactoring appears to be consistent and correct across the entire pull request.

chatgpt-codex-connector bot reviewed

View reviewed changes

chatgpt-codex-connector bot left a comment

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

vllm/v1/executor/abstract.py Outdated Show resolved Hide resolved

vllm/v1/executor/abstract.py Outdated Show resolved Hide resolved

vllm/v1/executor/abstract.py Show resolved Hide resolved

njhill marked this pull request as draft

October 18, 2025 06:04

njhill mentioned this pull request

[Misc] make get_class check for Executor instead of ExecutorBase #19914

Closed

4 tasks

njhill added 6 commits

October 18, 2025 15:15


          [Core] Remove V0 Executors

ec06b40

Signed-off-by: Nick Hill <nhill@redhat.com>


          consolidate UniProcExecutor

2ba4d11

Signed-off-by: Nick Hill <nhill@redhat.com>


          move remaining ray stuff

d5730a3

Signed-off-by: Nick Hill <nhill@redhat.com>


          use Executor rather than ExecutorBase for base class

87f030e

Signed-off-by: Nick Hill <nhill@redhat.com>


          coalesce Executor and BaseExecutor

bce515b

Signed-off-by: Nick Hill <nhill@redhat.com>


          minor

c4acc52

Signed-off-by: Nick Hill <nhill@redhat.com>


          update ray_utils module in lazy-loading dict

e67c090

Signed-off-by: Nick Hill <nhill@redhat.com>

njhill unassigned sangstar

mergify bot assigned sangstar

njhill changed the title ~~[Core] Remove V0 executors~~ [V0 Deprecation] Remove V0 executors

Member Author

njhill commented Oct 20, 2025

cc @ruisearch42 re the Ray executor changes

njhill added 2 commits

October 20, 2025 16:31

fix

068ad8e

Signed-off-by: Nick Hill <nhill@redhat.com>


          Merge remote-tracking branch 'origin/main' into rm-v0-executors

fbafe2c

mergify bot commented Oct 21, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @njhill.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify bot added the needs-rebase label


          Merge remote-tracking branch 'origin/main' into rm-v0-executors

fe6baf8

# Conflicts:
#	vllm/engine/metrics.py

mergify bot removed the needs-rebase label

njhill added 2 commits

October 20, 2025 20:28


          remove missed v0 worker method

Signed-off-by: Nick Hill <nhill@redhat.com>


          Merge remote-tracking branch 'origin/main' into rm-v0-executors

7e40c01

simon-mo approved these changes

View reviewed changes

njhill merged commit 647214f into vllm-project:main

56 checks passed

njhill deleted the rm-v0-executors branch

October 21, 2025 18:09

baonudesifeizhai pushed a commit to baonudesifeizhai/vllm that referenced this pull request


          [V0 Deprecation] Remove V0 executors (vllm-project#27142)

2f5100d

Signed-off-by: Nick Hill <nhill@redhat.com>

This was referenced Oct 23, 2025

Upgrade to new vllm commit and Refactor DeepSeekV3.2 vllm-project/vllm-ascend#3644

Closed

Upgrade to new vllm commit vllm-project/vllm-ascend#3663

Closed

sstamenk pushed a commit to sstamenk/vllm that referenced this pull request


          [V0 Deprecation] Remove V0 executors (vllm-project#27142)

b4601a4

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: sstamenk <strahinja.stamenkovic@amd.com>

Kay-Tian mentioned this pull request

vLLM PR #27142 变更核心文件提醒 Kay-Tian/vllm#22

Closed

usberkeley pushed a commit to usberkeley/vllm that referenced this pull request


          [V0 Deprecation] Remove V0 executors (vllm-project#27142)

84bbb73

Signed-off-by: Nick Hill <nhill@redhat.com>

albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request


          [V0 Deprecation] Remove V0 executors (vllm-project#27142)

63e4962

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>

wxsIcey mentioned this pull request

Upgrade to new vllm commit vllm-project/vllm-ascend#3719

Merged

njhill mentioned this pull request

Remove V0 Ray executor and migrate V1 implementation #25213

Open

wangxiyuan pushed a commit to vllm-project/vllm-ascend that referenced this pull request


          Upgrade to new vllm commit (#3719)

d9cdc65

### What this PR does / why we need it?
Upgrade to new vllm commit:
vllm-project/vllm@c9461e0

- Fix many imports, caused by
vllm-project/vllm#26908
- Fix import ```sha256```, caused by
vllm-project/vllm#27169
- Remove ```SchedulerConfig.send_delta_data```, caused by
vllm-project/vllm#27142
- Fix ```FusedMoE``` because of dual stream execution, caused by
vllm-project/vllm#26440

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
CI passed with new added/existing test.


- vLLM version: v0.11.0rc3
- vLLM main:
vllm-project/vllm@17c540a

---------

Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: Icey <1790571317@qq.com>
Co-authored-by: MengqingCao <cmq0113@163.com>

liziyu179 pushed a commit to nwpu-zxr/vllm-ascend that referenced this pull request


          Upgrade to new vllm commit (vllm-project#3719)

083e6cd

### What this PR does / why we need it?
Upgrade to new vllm commit:
vllm-project/vllm@c9461e0

- Fix many imports, caused by
vllm-project/vllm#26908
- Fix import ```sha256```, caused by
vllm-project/vllm#27169
- Remove ```SchedulerConfig.send_delta_data```, caused by
vllm-project/vllm#27142
- Fix ```FusedMoE``` because of dual stream execution, caused by
vllm-project/vllm#26440

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
CI passed with new added/existing test.

- vLLM version: v0.11.0rc3
- vLLM main:
vllm-project/vllm@17c540a

---------

Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: Icey <1790571317@qq.com>
Co-authored-by: MengqingCao <cmq0113@163.com>
Signed-off-by: nwpu-zxr <zhouxuerong2@huawei.com>

0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request


          [V0 Deprecation] Remove V0 executors (vllm-project#27142)

e51c9b6

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>

0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request


          [V0 Deprecation] Remove V0 executors (vllm-project#27142)

0cee750

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>

Chenyaaang pushed a commit to Chenyaaang/vllm that referenced this pull request


          [V0 Deprecation] Remove V0 executors (vllm-project#27142)

fcbd6db

Signed-off-by: Nick Hill <nhill@redhat.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hmellor hmellor left review comments

chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

simon-mo simon-mo approved these changes

youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

mgoin Awaiting requested review from mgoin mgoin is a code owner

tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

houseroad Awaiting requested review from houseroad houseroad is a code owner

yewentao256 Awaiting requested review from yewentao256 yewentao256 is a code owner

ProExpertProg Awaiting requested review from ProExpertProg ProExpertProg is a code owner

aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

chaunceyjiang Awaiting requested review from chaunceyjiang chaunceyjiang is a code owner

zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

comaniac Awaiting requested review from comaniac comaniac is a code owner

22quinn Awaiting requested review from 22quinn 22quinn is a code owner

+2 more reviewers

gemini-code-assist[bot] gemini-code-assist[bot] left review comments

markmc markmc approved these changes

Labels

frontend ready tpu v1