-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[NIXL][XPU] update name of nixl wheel #27631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the search pattern for finding the NIXL wheel file to accommodate a change in the wheel's filename format. While the change fixes the immediate issue, the new glob pattern is a bit too broad and could potentially match unrelated wheel files. I've suggested a more specific approach using two glob patterns to make the search more robust, ensuring it correctly identifies both old and new filename formats without accidentally picking up other packages.
| search_pattern = os.path.join(cache_dir, "nixl*.whl") | ||
| wheels = glob.glob(search_pattern) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The glob pattern nixl*.whl is a bit too broad. It would match any file starting with nixl and ending with .whl, such as a hypothetical nixltools-1.0.whl. This could lead to selecting the wrong wheel file if multiple such files exist in the cache and the sort order is not favorable.
To make the search more robust, it's better to use two more specific glob patterns: one for the old format (nixl-*.whl) and one for the new format (nixl_*-*.whl). This ensures we only match wheels for the nixl package, accommodating both naming conventions while being less likely to match unrelated packages.
| search_pattern = os.path.join(cache_dir, "nixl*.whl") | |
| wheels = glob.glob(search_pattern) | |
| wheels = glob.glob(os.path.join(cache_dir, "nixl-*.whl")) | |
| wheels.extend(glob.glob(os.path.join(cache_dir, "nixl_*-*.whl"))) |
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com> Signed-off-by: Bhagyashri <Bhagyashri.Gaikwad2@ibm.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
|
In the next NIXL release, the package will be split into You are installing only This is still in the works so it may make sense to wait a week or so for things to stabilize |
Thanks, I'll keep tracking this. |
…ect#389) Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
The recent update of NIXL's whl filename (
nixl_cu12-0.6.1-cp312-cp312-linux_x86_64.whl) causedfind_nixl_wheel_in_cacheto fail.