use_aot_compile should respect VLLM_DISABLE_COMPILE_CACHE
#27698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boyuan Feng <boyuan@meta.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly ensures that use_aot_compile respects the VLLM_DISABLE_COMPILE_CACHE environment variable by adjusting its default behavior. The changes also include a nice refactoring that centralizes the logic for VLLM_DISABLE_COMPILE_CACHE into a dedicated function, removing code duplication. The implementation is clean, correct, and improves the maintainability of the code.
ProExpertProg
approved these changes
Oct 29, 2025
zhxchen17
approved these changes
Oct 29, 2025
Contributor
zhxchen17
left a comment
zhxchen17
left a comment
There was a problem hiding this comment.
yeah this makes sense to me
zou3519
approved these changes
Oct 29, 2025
MatthewBonanni
pushed a commit
to MatthewBonanni/vllm
that referenced
this pull request
Oct 30, 2025
…roject#27698) Signed-off-by: Boyuan Feng <boyuan@meta.com>
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
…roject#27698) Signed-off-by: Boyuan Feng <boyuan@meta.com>
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
…roject#27698) Signed-off-by: Boyuan Feng <boyuan@meta.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…roject#27698) Signed-off-by: Boyuan Feng <boyuan@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aot_compile is part of torch.compile. So
use_aot_compileshould respectVLLM_DISABLE_COMPILE_CACHE.cc @zou3519 @ProExpertProg @zhxchen17