-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[CI Test] Add Scheduled Integration Test #27765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new scheduled integration tests for DeepSeek V2-Lite and Qwen3-30B models. The changes include new test scripts and updates to the Buildkite pipeline configuration. My review focuses on improving the robustness and reliability of the new test scripts. I've identified a couple of critical issues related to process management and file path handling that could lead to flaky or failing tests in a CI environment. The suggested changes aim to make the scripts safer and more reliable.
.buildkite/scripts/scheduled_integration_test/deepseek_v2_lite_ep_eplb.sh
Outdated
Show resolved
Hide resolved
.buildkite/scripts/scheduled_integration_test/qwen30b_a3b_fp8_block_ep.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.buildkite/scripts/scheduled_integration_test/deepseek_v2_lite_ep_eplb.sh
Outdated
Show resolved
Hide resolved
.buildkite/scripts/scheduled_integration_test/deepseek_v2_lite_ep_eplb.sh
Outdated
Show resolved
Hide resolved
.buildkite/scripts/scheduled_integration_test/qwen30b_a3b_fp8_block_ep.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
|
Lint passed. Given this only adds optional nightly tests, and verified passing (@yewentao256 plz add links in description) , merging. |
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Purpose
Set up tests for local node first (Most of the issues recently could be reproduced using a node)
Scheduled to run daily
After this get landed, we can update the schedule in buildkite
Test Plan
Currently we are going to conduct tests below:
Test
https://buildkite.com/vllm/ci/builds/37001#_ shows that is ready.