Skip to content

Conversation

@FlamingoPg
Copy link
Contributor

@FlamingoPg FlamingoPg commented Oct 30, 2025

Purpose

This PR is to support the Ouro model inference

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the new-model Requests to new models label Oct 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds support for the Ouro model. The implementation is largely adapted from the Qwen2 model. However, there are critical issues with the implementation of pipeline parallelism, which is currently broken. Additionally, a key feature of the Ouro model, early exiting, is initialized but not implemented in the forward pass. These issues need to be addressed to ensure correctness and full feature support.

FlamingoPg and others added 5 commits October 30, 2025 14:30
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
["hidden_states", "residual"], config.hidden_size
)
self.norm = RMSNorm(config.hidden_size, eps=config.rms_norm_eps)
self.early_exit_gate = RowParallelLinear(config.hidden_size, 1, bias=True)
Copy link
Collaborator

@jeejeelee jeejeelee Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this linear is unused
Maybe this PR is WIP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, we not use early exit in vllm. It's hard to handle kv cache here.

@jeejeelee
Copy link
Collaborator

Don't forget update model doc and model test

@FlamingoPg
Copy link
Contributor Author

Don't forget update model doc and model test

Thanks for review!

Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
@mergify
Copy link

mergify bot commented Oct 30, 2025

Documentation preview: https://vllm--27794.org.readthedocs.build/en/27794/

@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 30, 2025
youkaichao and others added 3 commits October 30, 2025 19:05
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
fix
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
@youkaichao youkaichao merged commit 9956aae into vllm-project:main Oct 30, 2025
4 of 5 checks passed
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: yinfan.1024 <yinfan.1024@bytedance.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: yinfan.1024 <yinfan.1024@bytedance.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
eldarkurtic pushed a commit to eldarkurtic/vllm that referenced this pull request Nov 12, 2025
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: yinfan.1024 <yinfan.1024@bytedance.com>
Co-authored-by: youkaichao <youkaichao@gmail.com>
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Eldar Kurtic <8884008+eldarkurtic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation new-model Requests to new models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants