-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Model][Ouro] Support Ouro Model #27794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR adds support for the Ouro model. The implementation is largely adapted from the Qwen2 model. However, there are critical issues with the implementation of pipeline parallelism, which is currently broken. Additionally, a key feature of the Ouro model, early exiting, is initialized but not implemented in the forward pass. These issues need to be addressed to ensure correctness and full feature support.
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
| ["hidden_states", "residual"], config.hidden_size | ||
| ) | ||
| self.norm = RMSNorm(config.hidden_size, eps=config.rms_norm_eps) | ||
| self.early_exit_gate = RowParallelLinear(config.hidden_size, 1, bias=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this linear is unused
Maybe this PR is WIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, we not use early exit in vllm. It's hard to handle kv cache here.
|
Don't forget update model doc and model test |
Thanks for review! |
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com>
|
Documentation preview: https://vllm--27794.org.readthedocs.build/en/27794/ |
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: yinfan.1024 <yinfan.1024@bytedance.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: yinfan.1024 <yinfan.1024@bytedance.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: yinfan.1024 <yinfan.1024@bytedance.com> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: yinfan.1024 <yinfan.1024@bytedance.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Eldar Kurtic <8884008+eldarkurtic@users.noreply.github.com>
Purpose
This PR is to support the Ouro model inference
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.