[Bugfix] Update inductor_partition_rule_context to use new inductor API #28067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artition op API Summary: Update inductor_partition_rule_context to try the new torch._inductor.config API first, falling back to the deprecated _custom_should_partition_fns API for compatibility with older torch versions. This prepares the codebase for future torch releases that remove the old API. Signed off by: Yanan Cao <gmagogsfm@gmail.com> Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
gmagogsfm
requested review from
ProExpertProg,
youkaichao and
zou3519
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates inductor_partition_rule_context to support a new API in torch._inductor.config while maintaining backward compatibility with the old API. The change is well-structured, using a try...except block to handle different torch versions. My main feedback is to refactor the implementation to reduce code duplication, which will improve maintainability.
Contributor
Author
|
@zou3519 @ProExpertProg Please review, thanks. |
Collaborator
|
Cc @BoyuanFeng |
Contributor
|
Thanks for the PR! We have something similar in #27702 |
Contributor
Author
|
This is a dupe of #27702, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update inductor_partition_rule_context to try the new torch._inductor.config API first, falling back to the deprecated _custom_should_partition_fns API for compatibility with older torch versions. This prepares the codebase for future torch releases that remove the old API.
This fixes test failures:
Signed off by: Yanan Cao gmagogsfm@gmail.com