Fix an endless loop issue when engine_step throws a RuntimeError #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Jul 3, 2023
Member
zhuohan123
left a comment
zhuohan123
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution!
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
yukavio
pushed a commit
to yukavio/vllm
that referenced
this pull request
Jul 3, 2024
This PR updates the benchmarking performed in remote-push and nightly runs according to the first set of deliverables from our recent meeting: * Only the `benchmark_serving.json` config is run * This is accomplished with a new list, `nm_benchmark_base_config_list.txt`, other lists are untouched * The `benchmark_serving.json` has various reductions: * Model list reduced to `facebook/opt-350m` and `meta-llama/Meta-Llama-3-8B-Instruct` * `nr-qps` list reduced to `300,1` * Metric tracking reduced to mean TPOT and mean TTFT (other metrics still recorded/logged per usual) There is also a small fix related to server startup (changing from `localhost` to `127.0.0.1` because `localhost` on the machines is mapped to the IPv6 `::1` which something in the server stack doesn’t seem to like). In a commit prior to opening the PR with all functional changes, the full `benchmark` job took <30 min: https://github.com/neuralmagic/nm-vllm/actions/runs/9669361155/job/26709082658
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Sep 30, 2024
…th LoRA (vllm-project#339) This PR has following fixes, - Increase size of indices tensors used to maintain multi-lora state information from max_num_batched_tokens to 3*max_num_batched_tokens. This increase is done to provide buffer for padding done in batch & sequence dimensions. - Move logic to remove padding from lora_logits from execute_model() back to Class LogitsProcessorWithLoRA, this is done to fix race condition caused by updating multi-lora state information directly. FIX HabanaAI#237
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Sep 19, 2025
Signed-off-by: Yan Ma <yan.ma@intel.com>
yma11
added a commit
to yma11/vllm
that referenced
this pull request
Oct 25, 2025
Signed-off-by: Yan Ma <yan.ma@intel.com>
yma11
added a commit
to yma11/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Yan Ma <yan.ma@intel.com>
yma11
added a commit
to yma11/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Yan Ma <yan.ma@intel.com>
yma11
added a commit
to yma11/vllm
that referenced
this pull request
Oct 28, 2025
Signed-off-by: Yan Ma <yan.ma@intel.com>
yma11
added a commit
to yma11/vllm
that referenced
this pull request
Oct 30, 2025
Signed-off-by: Yan Ma <yan.ma@intel.com>
yma11
added a commit
to yma11/vllm
that referenced
this pull request
Oct 31, 2025
Signed-off-by: Yan Ma <yan.ma@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.