From 312bd19b4162ac244faa135ee1cc9ce06c38237c Mon Sep 17 00:00:00 2001 From: Mor Zusman Date: Tue, 9 Jul 2024 21:31:33 +0300 Subject: [PATCH] get_and_reset only when scheduler is not empty --- vllm/engine/async_llm_engine.py | 4 ++-- vllm/engine/llm_engine.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vllm/engine/async_llm_engine.py b/vllm/engine/async_llm_engine.py index 33e40c7b3624a..f742fd048c653 100644 --- a/vllm/engine/async_llm_engine.py +++ b/vllm/engine/async_llm_engine.py @@ -224,11 +224,11 @@ async def step_async( """ seq_group_metadata_list, scheduler_outputs = self.scheduler[ virtual_engine].schedule() - finished_requests_ids = self.scheduler[ - virtual_engine].get_and_reset_finished_requests_ids() if not scheduler_outputs.is_empty(): # Execute the model. + finished_requests_ids = self.scheduler[ + virtual_engine].get_and_reset_finished_requests_ids() execute_model_req = ExecuteModelRequest( seq_group_metadata_list=seq_group_metadata_list, blocks_to_swap_in=scheduler_outputs.blocks_to_swap_in, diff --git a/vllm/engine/llm_engine.py b/vllm/engine/llm_engine.py index de7604ece7c31..1f735b5710287 100644 --- a/vllm/engine/llm_engine.py +++ b/vllm/engine/llm_engine.py @@ -846,10 +846,10 @@ def step(self) -> List[Union[RequestOutput, EmbeddingRequestOutput]]: "as performance will be severely degraded otherwise.") seq_group_metadata_list, scheduler_outputs = self.scheduler[ 0].schedule() - finished_requests_ids = self.scheduler[ - 0].get_and_reset_finished_requests_ids() if not scheduler_outputs.is_empty(): + finished_requests_ids = self.scheduler[ + 0].get_and_reset_finished_requests_ids() execute_model_req = ExecuteModelRequest( seq_group_metadata_list=seq_group_metadata_list, blocks_to_swap_in=scheduler_outputs.blocks_to_swap_in,