diff --git a/changelogs/unreleased/1565-GuessWhoSamFoo b/changelogs/unreleased/1565-GuessWhoSamFoo new file mode 100644 index 0000000000..9f8005d5a8 --- /dev/null +++ b/changelogs/unreleased/1565-GuessWhoSamFoo @@ -0,0 +1 @@ +Fixed Daemonset incorrectly showing status when pod is unavailable diff --git a/internal/objectstatus/daemonset.go b/internal/objectstatus/daemonset.go index f78398e7a7..105aeb3e96 100644 --- a/internal/objectstatus/daemonset.go +++ b/internal/objectstatus/daemonset.go @@ -36,7 +36,7 @@ func daemonSet(_ context.Context, object runtime.Object, _ store.Store) (ObjectS nodeStatus: component.NodeStatusWarning, Details: []component.Component{component.NewText("Daemon Set pods are running on nodes that aren't supposed to run Daemon Set pods")}, }, nil - case status.NumberAvailable != status.NumberReady: + case status.DesiredNumberScheduled != status.NumberReady: return ObjectStatus{ nodeStatus: component.NodeStatusWarning, Details: []component.Component{component.NewText("Daemon Set pods are not ready")}, diff --git a/pkg/view/component/button.go b/pkg/view/component/button.go index 9eedafda16..cd07de78f0 100644 --- a/pkg/view/component/button.go +++ b/pkg/view/component/button.go @@ -29,7 +29,7 @@ type ButtonStatus string const ( // ButtonSizeBlock is a full width button ButtonSizeBlock ButtonSize = "block" - // ButtonSizeLarge is a small button + // ButtonSizeMedium is a clarity small button ButtonSizeMedium ButtonSize = "md" )