From 4b684f81c56980fed243143ef27372b5030bcd0c Mon Sep 17 00:00:00 2001 From: mivaylo <132376042+mivaylo@users.noreply.github.com> Date: Tue, 12 Mar 2024 16:42:33 +0200 Subject: [PATCH] feat: add support for Angular 17 (#1312) ## PR Checklist Please check if your PR fulfills the following requirements: - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [x] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Issue Number: CDE-1597 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No ## Other information This is not exactly port (as it was not cherrypicked) but it adds the same change as this PR: https://github.com/vmware-clarity/ng-clarity/pull/1094 Tested with this PR: https://github.com/vmware-clarity/ng-clarity/pull/1313 --- .github/workflows/pr-build.yml | 10 +++++++--- projects/angular/package.json | 6 +++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-build.yml b/.github/workflows/pr-build.yml index ac3a8bb453..fefcac3b3a 100644 --- a/.github/workflows/pr-build.yml +++ b/.github/workflows/pr-build.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - angular: ['Angular v15', 'Angular v16'] + angular: ['Angular v15', 'Angular v16', 'Angular v17'] steps: - name: Checkout uses: actions/checkout@v3 @@ -22,11 +22,15 @@ jobs: - name: Install Dependencies run: npm ci - name: Update to Angular v16 - if: ${{matrix.angular == 'Angular v16'}} + if: ${{matrix.angular == 'Angular v16' || matrix.angular == 'Angular v17'}} run: | npx ng update @angular/core@16 @angular/common@16 @angular/cli@16 @angular/cdk@16 --force + - name: Update to Angular v17 + if: ${{matrix.angular == 'Angular v17'}} + run: | + npx ng update @angular/core@17 @angular/common@17 @angular/cli@17 @angular/cdk@17 --allow-dirty --force - name: Disable Storybook Build - if: ${{matrix.angular == 'Angular v16'}} + if: ${{matrix.angular != 'Angular v15'}} run: node ./scripts/clear-npm-script.js _build:storybook - name: Lint if: ${{matrix.angular == 'Angular v15'}} diff --git a/projects/angular/package.json b/projects/angular/package.json index 43822ebf34..92348bd9be 100644 --- a/projects/angular/package.json +++ b/projects/angular/package.json @@ -18,9 +18,9 @@ "url": "https://github.com/vmware-clarity/ng-clarity/issues" }, "peerDependencies": { - "@angular/cdk": "15 || 16", - "@angular/common": "15 || 16", - "@angular/core": "15 || 16", + "@angular/cdk": "15 || 16 || 17", + "@angular/common": "15 || 16 || 17", + "@angular/core": "15 || 16 || 17", "@cds/core": ">= 6.7.0" } }