-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement the reconciler for SubnetConnectionBindingMap (#901)
1. Implement the reconciler for SubnetConnectionBindingMap, it may update the SubnetConnectionBindingMap status with condition ready is false if its dependent Subnet or SubnetSet is not ready (or realized) or it hits errors when realizing NSX SubnetConnectionBindingMaps. It updates the status with ready condition as true if it is successfully realized on NSX. The reconciler also watches the Subnet/SubnetSet CR events to sync the connection binding maps. 2. The change also modifies the Subnet/SubnetSet reconciler to watch SubnetConnectionBindingMap CR events. If a Subnet/SubnetSet is used by a SubnetConnectionBindingMap, a finalizer is added on the corresponding Subnet/SubnetSet CR, and the finalizer is removed automatically if the CR is not used by any SubnetConnectionBindingMaps.
- Loading branch information
Showing
35 changed files
with
4,971 additions
and
104 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| package common | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| "k8s.io/client-go/util/workqueue" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/event" | ||
| "sigs.k8s.io/controller-runtime/pkg/predicate" | ||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
|
|
||
| "github.com/vmware-tanzu/nsx-operator/pkg/apis/vpc/v1alpha1" | ||
| ) | ||
|
|
||
| type RequeueObjectByEvent func(ctx context.Context, c client.Client, obj client.Object, q workqueue.TypedRateLimitingInterface[reconcile.Request]) | ||
| type RequeueObjectByUpdate func(ctx context.Context, c client.Client, objOld client.Object, objNew client.Object, q workqueue.TypedRateLimitingInterface[reconcile.Request]) | ||
|
|
||
| type EnqueueRequestForDependency struct { | ||
| Client client.Client | ||
| ResourceType string | ||
| RequeueByCreate RequeueObjectByEvent | ||
| RequeueByDelete RequeueObjectByEvent | ||
| RequeueByUpdate RequeueObjectByUpdate | ||
| } | ||
|
|
||
| func (e *EnqueueRequestForDependency) Create(ctx context.Context, ev event.CreateEvent, q workqueue.TypedRateLimitingInterface[reconcile.Request]) { | ||
| obj := ev.Object | ||
| log.V(1).Info(fmt.Sprintf("%s create event", e.ResourceType), "Namespace", obj.GetNamespace(), "Name", obj.GetName()) | ||
| if e.RequeueByCreate != nil { | ||
| e.RequeueByCreate(ctx, e.Client, obj, q) | ||
| } | ||
| } | ||
|
|
||
| func (e *EnqueueRequestForDependency) Delete(ctx context.Context, ev event.DeleteEvent, q workqueue.TypedRateLimitingInterface[reconcile.Request]) { | ||
| obj := ev.Object | ||
| log.V(1).Info(fmt.Sprintf("%s delete event", e.ResourceType), "Namespace", obj.GetNamespace(), "Name", obj.GetName()) | ||
| if e.RequeueByDelete != nil { | ||
| e.RequeueByDelete(ctx, e.Client, obj, q) | ||
| } | ||
| } | ||
|
|
||
| func (e *EnqueueRequestForDependency) Generic(_ context.Context, _ event.GenericEvent, _ workqueue.TypedRateLimitingInterface[reconcile.Request]) { | ||
| log.V(1).Info(fmt.Sprintf("%s generic event, do nothing", e.ResourceType)) | ||
| } | ||
|
|
||
| func (e *EnqueueRequestForDependency) Update(ctx context.Context, ev event.UpdateEvent, q workqueue.TypedRateLimitingInterface[reconcile.Request]) { | ||
| objNew := ev.ObjectNew | ||
| log.V(1).Info(fmt.Sprintf("%s update event", e.ResourceType), "Namespace", objNew.GetNamespace(), "Name", objNew.GetName()) | ||
| if e.RequeueByUpdate != nil { | ||
| objOld := ev.ObjectOld | ||
| e.RequeueByUpdate(ctx, e.Client, objOld, objNew, q) | ||
| } | ||
| } | ||
|
|
||
| func IsObjectUpdateToReady(oldConditions []v1alpha1.Condition, newConditions []v1alpha1.Condition) bool { | ||
| return !IsObjectReady(oldConditions) && IsObjectReady(newConditions) | ||
| } | ||
|
|
||
| func IsObjectUpdateToUnready(oldConditions []v1alpha1.Condition, newConditions []v1alpha1.Condition) bool { | ||
| return IsObjectReady(oldConditions) && !IsObjectReady(newConditions) | ||
| } | ||
|
|
||
| func IsObjectReady(conditions []v1alpha1.Condition) bool { | ||
| for _, con := range conditions { | ||
| if con.Type == v1alpha1.Ready && con.Status == corev1.ConditionTrue { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| var PredicateFuncsWithSubnetBindings = predicate.Funcs{ | ||
| CreateFunc: func(e event.CreateEvent) bool { | ||
| return true | ||
| }, | ||
| UpdateFunc: func(e event.UpdateEvent) bool { | ||
| oldBindingMap := e.ObjectOld.(*v1alpha1.SubnetConnectionBindingMap) | ||
| newBindingMap := e.ObjectNew.(*v1alpha1.SubnetConnectionBindingMap) | ||
| if oldBindingMap.Spec.TargetSubnetSetName != newBindingMap.Spec.TargetSubnetSetName || | ||
| oldBindingMap.Spec.TargetSubnetName != newBindingMap.Spec.TargetSubnetName { | ||
| return true | ||
| } | ||
| return false | ||
| }, | ||
| DeleteFunc: func(e event.DeleteEvent) bool { return true }, | ||
| GenericFunc: func(e event.GenericEvent) bool { | ||
| return false | ||
| }, | ||
| } |
Oops, something went wrong.