Add support for pre-created VPC in VPCNetworkConfiguration CR #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyingd
force-pushed
the
precreated_vpc_ns-controller
branch
4 times, most recently
from
e287912 to
2a922d5
Compare
wenyingd
force-pushed
the
precreated_vpc_ns-controller
branch
from
2a922d5 to
58eb9c0
Compare
zhengxiexie
reviewed
Aug 19, 2024
TaoZou1
reviewed
Aug 19, 2024
wenyingd
force-pushed
the
precreated_vpc_ns-controller
branch
from
58eb9c0 to
4082703
Compare
zhengxiexie
previously approved these changes
Aug 19, 2024
TaoZou1
previously approved these changes
Aug 19, 2024
heypnus
reviewed
Aug 19, 2024
wenyingd
force-pushed
the
precreated_vpc_ns-controller
branch
from
4082703 to
da650d1
Compare
wenyingd
force-pushed
the
precreated_vpc_ns-controller
branch
from
da650d1 to
b1b5a45
Compare
dantingl
reviewed
Aug 19, 2024
wenyingd
changed the title
wenyingd
force-pushed
the
precreated_vpc_ns-controller
branch
from
b1b5a45 to
8409847
Compare
heypnus
previously approved these changes
Aug 20, 2024
dantingl
previously approved these changes
Aug 20, 2024
1. Skip NSX VPC creations if VPC field is set in the VPCNetworkConfiguration CR spec. 2. Using the pre-created VPC's private IPs. connectivity profile and other necessary settings to set NetworkInfo CR status. 3. Add tag "nsx/managed-by: nsx-op" on the NSX VPCs which are created by nsx-operator.
wenyingd
force-pushed
the
precreated_vpc_ns-controller
branch
from
8409847 to
a835ed9
Compare
dantingl
approved these changes
Aug 20, 2024
heypnus
approved these changes
Aug 20, 2024
wenyingd
added a commit
to wenyingd/nsx-operator
that referenced
this pull request
Aug 21, 2024
…vmware-tanzu#683)" This reverts commit f6f2ebf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec.
necessary settings to set NetworkInfo CR status.
nsx-operator.