-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validations for SubnetPort CRD #869
Add validations for SubnetPort CRD #869
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 73.36% 73.38% +0.02%
==========================================
Files 109 109
Lines 15235 15248 +13
==========================================
+ Hits 11177 11190 +13
Misses 3307 3307
Partials 751 751
|
/e2e |
f2764e0
to
d1d99df
Compare
e2e |
/e2e |
Shall we remove the check in subnetport controller for this validation? nsx-operator/pkg/controllers/subnetport/subnetport_controller.go Lines 82 to 87 in bf1880a
|
d1d99df
to
e04dc93
Compare
thanks,removed. |
Fix the UT? |
71c3220
to
845e018
Compare
808b2b3
to
a707ed5
Compare
/e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1a351aa
to
a336862
Compare
Add validations for SubnetPort CR to specify one of subnet or subnetSet under spec.
a336862
to
fb2defe
Compare
Add validations for SubnetPort CR to specify one of subnet or subnetSet under spec.