Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if we want to have 1 plugin manager per scope (server, backup, restore) or 1 overall #601

Closed
ncdc opened this issue Jun 25, 2018 · 2 comments
Labels
Enhancement/Dev Internal or Developer-focused Enhancement to Velero
Milestone

Comments

@ncdc
Copy link
Contributor

ncdc commented Jun 25, 2018

In #495 (not yet merged), each "scope" gets its own plugin.Manager - the Ark server, each backup, and each restore. This has a higher memory cost if/when we support simultaneous backups or restores (each backup/restore has to load a full set of plugins). Using a unique manager per scope, however, makes it easier to distinguish log messages - we can easily direct logs from an individual backup's set of plugins to the backup's log file.

An alternative would be to have a single set of plugins, and use a structured log field to "route" messages to the right log destination.

@ncdc ncdc added the Enhancement/Dev Internal or Developer-focused Enhancement to Velero label Jun 25, 2018
@ncdc ncdc added this to the v1.0.0 milestone Jun 25, 2018
@skriss
Copy link
Contributor

skriss commented Nov 1, 2018

@ncdc would you consider this question closed by now?

@ncdc
Copy link
Contributor Author

ncdc commented Nov 1, 2018

Yes, I think the way things are working now is good. Thanks for checking!

@ncdc ncdc closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/Dev Internal or Developer-focused Enhancement to Velero
Projects
None yet
Development

No branches or pull requests

2 participants