velero server: log version and git SHA at startup #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
tweak-server-log-version
branch
from
e80a757 to
328bc36
Compare
skriss
changed the title
|
@nrb this one could go to since it's trivial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss krisss@vmware.com
We're currently only logging the Git SHA in the server log on startup. Log both the version and the Git SHA.
(Note: prior to #1124 this was actually displaying the version, because
FormattedGitSHA()actually showed a version number if it was a tagged commit. A/o 1124 this changed to actually displaying the git SHA. In any case, I'd like to show both)