Init schedule Prometheus metrics #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemaral
force-pushed
the
init-schedule-metrics
branch
from
126adc5
to
e14829f
Compare
|
Looks good, would you mind squashing the commits @lemaral ? |
…d (see https://prometheus.io/docs/practices/instrumentation/#avoid-missing-metrics) Signed-off-by: Alex Lemaresquier <alex+github@lemaresquier.org>
lemaral
force-pushed
the
init-schedule-metrics
branch
from
bd52aac
to
450fa72
Compare
|
LGTM |
skriss
approved these changes
Jul 23, 2018
|
Hi, thanks for merging this in! Do you know in which tag/release it will be available? We need this initialization for our Datadog monitoring setup to work correctly, but I'd like to avoid to point to master in production :) |
|
Hi @lemaral - sorry for the slow reply. We're in the middle of our planning for 0.10 release which should give us a better understanding of when this might land. We're also considering a 0.9.3 release, which could have this backported. I'll have more information for you tomorrow or Monday. |
|
FYI @lemaral we're going to cut a v0.9.3 with this PR for you :) . I expect it to go out today or tomorrow. |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize schedule Prometheus metrics to have them created beforehand (see https://prometheus.io/docs/practices/instrumentation/#avoid-missing-metrics)
Signed-off-by: Alex Lemaresquier alex+github@lemaresquier.org