Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp: add support for regional storage types #936

Closed
wants to merge 14 commits into from

Conversation

wwitzel3
Copy link
Contributor

The version of the Google API library we have vendored does not have the RegionDisks API.

I've attempted to use 15aea8711db98e640b277da9771a9d74270c2edc of google.golang.org/api but that results in some other compilation issues that I am unsure of how to fix currently.

vendor/google.golang.org/api/internal/creds.go:36:10: undefined: google.CredentialsFromJSON
Makefile:113: recipe for target 'shell' failed
make[2]: *** [shell] Error 2
make[2]: Leaving directory '/home/wwitzel3/go/src/github.com/heptio/ark'
Makefile:97: recipe for target '_output/bin/linux/amd64/ark' failed
make[1]: *** [_output/bin/linux/amd64/ark] Error 2
make[1]: Leaving directory '/home/wwitzel3/go/src/github.com/heptio/ark'
Makefile:67: recipe for target 'all' failed
make: *** [all] Error 2

Once I get the vendoring figured out, I'll add tests, and take this out of work in progress.

Fixes #765

carlisia and others added 11 commits October 2, 2018 12:41
Signed-off-by: Carlisia <carlisia@grokkingtech.io>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Carlisia <carlisia@grokkingtech.io>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Steve Kriss <steve@heptio.com>
…ckups

Update backups for volume snapshot locations
Signed-off-by: Steve Kriss <steve@heptio.com>
add --volume-snapshot-locations flag to ark backup create
@skriss
Copy link
Contributor

skriss commented Oct 15, 2018

@wwitzel3 guessing you'll also need to bump the rev of golang.org/x/oauth2 that we're using?

@wwitzel3
Copy link
Contributor Author

I'll give that a shot, thanks.

Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
@wwitzel3 wwitzel3 changed the title [WIP] gcp: add support for regional storage types gcp: add support for regional storage types Oct 15, 2018
@skriss skriss force-pushed the snapshot-locations branch from 63b11b0 to 406b50a Compare October 17, 2018 19:42
@skriss skriss closed this Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants