Allow to use AWS Signature v1 for creating signed AWS urls #998
Conversation
bashofmann
force-pushed
the
add-aws-s3-v1-signer
branch
2 times, most recently
from
57426e4 to
ab95b00
Compare
|
Could you add documentation for how the user would provide the algorithm version? |
|
Did you implement the v1 signing algorithm yourself or find it in another go project somewhere? |
Thanks! It may also be worth calling out on, in case a provider doesn't support v4 signing. https://github.com/heptio/ark/blob/master/docs/support-matrix.md#s3-compatible-backup-storage-providers |
Done |
| } | ||
|
|
||
| func (v1 *signer) Sign() error { | ||
| credValue, err := v1.Credentials.Get() |
There was a problem hiding this comment.
How about credentialsValue? credentials would clash with the imported package name.
|
@bashofmann LGTM here. You'll need to add an entry to @skriss please do a final review. Once Steve is 👍, please squash down to 1 commit and make sure it has the signoff. Thanks! |
|
LGTM pending |
Some aws implementations, for example the quobyte object storage, do not support the v4 signing algorithm, but only v1. This makes it possible to configure the signatureVersion. The algorithm implementation was ported from https://github.com/oNestLab/botocore/blob/d6c1be296e8cfe0706cb0c8bbcad9c095d0f4d09/botocore/auth.py#L860-L862 which is used by the aws CLI client. This fixes vmware-tanzu#811. Signed-off-by: Bastian Hofmann <bashofmann@gmail.com>
bashofmann
force-pushed
the
add-aws-s3-v1-signer
branch
from
1806971 to
e13806e
Compare
Some s3 implementations, for example the quobyte object storage, do not
support the v4 signing algorithm, but only v1.
This makes it possible to configure the signatureVersion.
The algorithm implementation was ported from https://github.com/oNestLab/botocore/blob/d6c1be296e8cfe0706cb0c8bbcad9c095d0f4d09/botocore/auth.py#L860-L862
which is used by the aws CLI client.
This fixes #811.