This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
build: fix build version numbers and use NPM #6066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathisscott
approved these changes
Jun 14, 2021
coryrylan
approved these changes
Jun 14, 2021
|
Adding GitHub checks back too. |
bdryanovski
reviewed
Jun 15, 2021
bdryanovski
reviewed
Jun 15, 2021
bdryanovski
reviewed
Jun 15, 2021
bdryanovski
reviewed
Jun 15, 2021
We need the version numbers to be updated correctly for distribution on NPM. We also don't want to install @clr/icons anymore as it is not used with v5+. Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
gnomeontherun
force-pushed
the
bugfix/angular-version-build
branch
from
506c6b3
to
195d738
Compare
|
✔️ Deploy Preview for angular-clarity-design ready! 🔨 Explore the source changes: e77e26b 🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-clarity-design/deploys/60c921799aa15b0007e42430 😎 Browse the preview: https://deploy-preview-6066--angular-clarity-design.netlify.app/src/app/card/card-old |
gnomeontherun
force-pushed
the
bugfix/angular-version-build
branch
2 times, most recently
from
e39599d
to
f7cfaae
Compare
mathisscott
approved these changes
Jun 15, 2021
gnomeontherun
force-pushed
the
bugfix/angular-version-build
branch
from
f7cfaae
to
9ab9be4
Compare
Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>
gnomeontherun
force-pushed
the
bugfix/angular-version-build
branch
from
9ab9be4
to
e77e26b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the version numbers to be updated correctly for distribution on NPM. We also don't want to install @clr/icons anymore as it is not used with v5+. We want to have @clr/angular point to @cds/core@^5.0.0, so fixed that in the schematic and package.
I also dropped
yarnfornpmas it will make it simpler.I tested this locally and it now installs correctly with ng add.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information