Improve error handling for policy resources #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of today, provied cannot rely on vapi converter to return conversion error in case target type does not match the actual content. This change works around this issue and prints raw error data whenever conversion is not succesful. In addition, avoid erroring when VMC token decoder returns an error, since for some error the token remains functional. Print a warning instead.
asarfaty
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today, provied cannot rely on vapi converter to return
conversion error in case target type does not match the actual
content. This change works around this issue and prints raw error
data whenever conversion is not succesful.
In addition, avoid erroring when VMC token decoder returns an error,
since for some error the token remains functional. Print a warning
instead.