Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip marked_for_delete data sources in search by name/type #516

Merged
merged 2 commits into from
Nov 29, 2020
Merged

Skip marked_for_delete data sources in search by name/type #516

merged 2 commits into from
Nov 29, 2020

Conversation

asarfaty
Copy link
Contributor

No description provided.

@asarfaty asarfaty requested review from enhaocui and annakhm November 23, 2020 09:58
@asarfaty asarfaty changed the title Skip marked_for_delete data sources in searh by name/type Skip marked_for_delete data sources in search by name/type Nov 23, 2020
annakhm
annakhm reviewed Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@annakhm annakhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the same check to listPolicyResourcesByID?

annakhm
annakhm approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@annakhm annakhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls ignore the website linter error - its already fixed

@asarfaty
Copy link
Contributor Author

Should we add the same check to listPolicyResourcesByID?

I'm not sure. I think if you ask for a specific ID you probably know what you want so its unlikely to be deleted. But we can if you think so.

@annakhm
Copy link
Collaborator

annakhm commented Nov 25, 2020

We should be consistent with LM behavior. Do you know if GET for an object would return it in case its marked for deletion?

@asarfaty
Copy link
Contributor Author

asarfaty commented Nov 25, 2020 •
edited
Loading

No. Regular GET (or LIST) does not return those

annakhm
annakhm approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@annakhm annakhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@asarfaty asarfaty merged commit 2baad1e into master Nov 29, 2020
@annakhm annakhm deleted the search_delete branch February 16, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annakhm annakhm annakhm approved these changes

@enhaocui enhaocui Awaiting requested review from enhaocui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asarfaty @annakhm