fix: not using quotes on column names #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eirikbell if you can verify that reverting this commit fixes it, let me know. |
|
If I understand correctly, "add quotas logic" (or whatever dialect-specific symbol) is implemented at the beginning of this method. Meanwhile, in this PR, extra quotas are added whether needed there or not. |
|
I can confirm that reverting the commit 4cd18bd will fix the issue |
eirikbell
added a commit
to eirikbell/sqlboiler
that referenced
this pull request
Jan 18, 2024
stephenafamo
added a commit
that referenced
this pull request
Jan 18, 2024
fix: revert #1322 fixing bug in v4.16.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix potential issue where column name like "createdAt" would not be using quotes