Add one click install script #345
Conversation
|
/assign @TommyLike |
volcano-sh-bot
added
the
size/L
hack/local-up-volcano.sh
Outdated
| # TODO: add a graceful way waiting for all crd ready | ||
| kubectl apply -f ${RELEASE_FOLDER}/${YAML_FILENAME} --kubeconfig ${KUBECONFIG} | ||
| sleep 5 | ||
| kubectl apply -f ${VK_ROOT}/installer/helm/chart/volcano/templates/default-queue.yaml --kubeconfig ${KUBECONFIG} |
There was a problem hiding this comment.
just have a retry should be enough :)
There was a problem hiding this comment.
I want to make the default-queue install into the scheduler if possible.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
@hzxuzhonghu It's better to update/add document along with this change, otherwise we need another one after this. |
|
|
||
| prepare | ||
|
|
||
| if [ "${INSTALL_MODE}" == "kind" ]; then |
There was a problem hiding this comment.
For the clusters other than kind cluster, how can user deploy the images into the cluster?
There was a problem hiding this comment.
good question: we can not know their registry. If they use one node development env, the image is on the host. But if it is a multi-node cluster, we can not do that for users.
There was a problem hiding this comment.
Need to mention this in the document or just support kind cluster, since for the other cases, they can deploy volcano via the installation guide.
Yes, but i am not sure where to put it. Any suggestion? |
Add a development section or individual document would be ok. |
Will do |
@SrinivasChilveri Could you help EDIT: this is done |
hzxuzhonghu
force-pushed
the
one-click-install
branch
from
8ac74ae
to
1d26a0c
Compare
|
ping @TommyLike ptal |
| Weight: 1, | ||
| }, | ||
| } | ||
| if _, err := kbClient.SchedulingV1alpha2().Queues().Create(&defaultQue); err != nil && !apierrors.IsAlreadyExists(err) { |
There was a problem hiding this comment.
What if I have a existing default-queue from the previous version of volcano?
There was a problem hiding this comment.
Does not matter
https://github.com/volcano-sh/volcano/blob/master/hack/publish.sh#L52 and https://github.com/volcano-sh/volcano/blob/master/installer/README.md both need update since the default-queue is not required now. |
|
This can be a follow up. |
|
/lgtm |
Added local-up-volcano.sh, developers can
Install kind cluster and then install volcano by
Install install volcano into a existing cluster