Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean some redundant job/pg/gc controllers code #405

Merged
merged 1 commit into from
Aug 3, 2019
Merged

clean some redundant job/pg/gc controllers code #405

merged 1 commit into from
Aug 3, 2019

Conversation

wangyuqing4
Copy link
Contributor

@wangyuqing4 wangyuqing4 commented Aug 3, 2019 •
edited
Loading

  1. job controller clean code work， delete kubebatch Clients

image

  1. job and podgroup use same sharedInformers， clear up some code

image

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 3, 2019
@TommyLike
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2019
@k82cn
Copy link
Member

k82cn commented Aug 3, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wangyuqing4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2019
@volcano-sh-bot volcano-sh-bot merged commit 8dd5a34 into volcano-sh:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

@TommyLike TommyLike Awaiting requested review from TommyLike

Assignees

@TommyLike TommyLike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangyuqing4 @TommyLike @k82cn @volcano-sh-bot