Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add comments about the defaulting of queue #408

Merged
merged 1 commit into from
Aug 7, 2019
Merged

fix: Add comments about the defaulting of queue #408

merged 1 commit into from
Aug 7, 2019

Conversation

gaocegege
Copy link
Contributor

@gaocegege gaocegege commented Aug 7, 2019 •
edited
Loading 

	// TODO(k82cn): set default queue in admission.
	if len(ss.Spec.Queue) == 0 {
		sc.Jobs[job].Queue = kbapi.QueueID(sc.defaultQueue)
	}

Since we will set the default queue for the PodGroup, we should note it in the API.

Signed-off-by: Ce Gao gaoce@caicloud.io

@gaocegege
fix: Add comments about the defaulting of queue
ab3a5f4 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@volcano-sh-bot
Copy link
Contributor

Welcome @gaocegege!

It looks like this is your first PR to volcano-sh/volcano 🎉.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2019
@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@k82cn
Copy link
Member

k82cn commented Aug 7, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@volcano-sh-bot volcano-sh-bot merged commit 370d612 into volcano-sh:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaocegege @volcano-sh-bot @hzxuzhonghu @k82cn