Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proportion OverusedFn #482

Merged
merged 1 commit into from
Oct 16, 2019
Merged

fix proportion OverusedFn #482

merged 1 commit into from
Oct 16, 2019

Conversation

wangyuqing4
Copy link
Contributor

fix Issue #479

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2019
@TravisBuddy
Copy link

Hey @wangyuqing4,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 884d5ed0-ef43-11e9-a922-b7efe53f32d4

@k82cn
Copy link
Member

k82cn commented Oct 15, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wangyuqing4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@k82cn
Copy link
Member

k82cn commented Oct 15, 2019

@hzxuzhonghu , it seems the bot can not help to merge codes.

@k82cn k82cn merged commit dab3f6e into volcano-sh:master Oct 16, 2019
@k82cn
Copy link
Member

k82cn commented Oct 16, 2019

I merged this PR manually :) @hzxuzhonghu , please hep to check the bot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants